dongjoon-hyun commented on PR #59965: URL: https://github.com/apache/spark/pull/59965#issuecomment-6546343849
Thank you for the review, @peter-toth ! All four findings are addressed in 045f67e3d98. 1. **Auto-filled rows failing a later validation:** The check of a provided value is now analyzed under the same settings as the auto-fill, and a new test covers it. A row stored earlier under ANSI off can now fail when a later write carries it, so the migration guide and the PR description describe that. 2. **Migration guide:** Added two entries under "Upgrading from Spark SQL 4.3 to 4.4", one for the writes and one for the DDL rejection. 3. **Unresolved nested result:** The behavior stays as you suggested. A code comment and the PR description now describe it. 4. **`size(arr)` test step:** Applied your suggestion. I replied in each thread with the details and updated the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
