dongjoon-hyun commented on PR #59965:
URL: https://github.com/apache/spark/pull/59965#issuecomment-6564063879
Thank you for the third review, @peter-toth ! I rebased this PR onto the
master branch to resolve the conflict in the migration guide, and the changes
below are in 0fd998404af. I addressed findings 14, 16, 17 and 21 to 23, and
kept 15, 18, 19 and 20 out of this PR.
14. **`DELETE` on rows that 4.3 stored:** The check of generated columns is
now skipped for a row-level `DELETE`, which writes no new generated value. An
`INSERT ... SELECT` of such a row still goes through the check, and the
migration guide says that.
15. **A provided value that casts to the generated one:** I reproduced this,
and your fix works. I kept it out of this PR, because it also changes the
default mode. The PR description lists the behavior under an ANSI-off writer.
16. **`IDENTIFIER('"a"')`:** An `AnalysisException` from the analysis under
the fixed settings now falls back to the session reading, for both the
auto-fill and the check.
17. **Migration guide:** Applied your wording about creating a new table and
copying the other columns.
18. **The V2 form:** No code change. It only matters for a table created
with ANSI off, on a connector that evaluates that form, and the PR description
lists it.
19. **A bare `CURRENT_DATE`:** No code change. The rejection happens at
CREATE, no wrong value is stored, and `curdate()` and `now()` are accepted.
20. **A struct field:** This predates this PR. I am working on a fix
separately, and will file a JIRA ticket for it.
21. **`.get`:** The write now fails with
`UNSUPPORTED_EXPRESSION_GENERATED_COLUMN`, which names the column and the
expression.
22. **`readGenerationExpr` defaults:** Partly applied. The V1 paths now read
under the session as on the base, and defaults remain only on the two recursive
methods.
23. **Connector docs:** Updated the `GenerationExpression` and `Column`
javadocs.
I replied in each thread with the details and updated the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
