dongjoon-hyun commented on code in PR #59965: URL: https://github.com/apache/spark/pull/59965#discussion_r4436656081
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StoredExpressionText.scala: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.util + +import org.apache.spark.sql.catalyst.analysis.{Analyzer, ExpressionWithUnresolvedIdentifier} +import org.apache.spark.sql.catalyst.expressions.{Alias, Expression, ExprId} +import org.apache.spark.sql.catalyst.parser.{ParseException, ParserInterface} +import org.apache.spark.sql.internal.SQLConf + +/** + * Reads the SQL text of an expression stored with a table, such as a CHECK condition or a + * generation expression, independently of the settings of the session that reads it. + */ +object StoredExpressionText { + + /** + * The settings a stored text is read under. The session time zone and case sensitivity stay with + * the given session, because the settings of the DDL are not known here and pinning them would + * silently change existing tables of a non-UTC or a case-sensitive deployment. + */ + def conf(session: SQLConf): SQLConf = { + val c = new SQLConf + Analyzer.retainResolutionConfigsForAnalysis(newConf = c, existingConf = session) + c.setConfString(SQLConf.ANSI_ENABLED.key, "true") + c.setConfString(SQLConf.SESSION_LOCAL_TIMEZONE.key, session.sessionLocalTimeZone) + c.setConfString(SQLConf.CASE_SENSITIVE.key, session.caseSensitiveAnalysis.toString) + c + } + + /** Parses `text` under [[conf]]. */ + def parse(parser: ParserInterface, text: String): Expression = { + SQLConf.withExistingConf(conf(SQLConf.get)) { Review Comment: I reproduced this, and it stores `x-temp` on both the base and 958490e358a. I kept it out of this PR, because the behavior is unchanged from the base and the PR description lists it. The rewrite will come in a separate PR, so that this PR stays about the settings. I did not run the SQL temporary function case. ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StoredExpressionText.scala: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.util + +import org.apache.spark.sql.catalyst.analysis.{Analyzer, ExpressionWithUnresolvedIdentifier} +import org.apache.spark.sql.catalyst.expressions.{Alias, Expression, ExprId} +import org.apache.spark.sql.catalyst.parser.{ParseException, ParserInterface} +import org.apache.spark.sql.internal.SQLConf + +/** + * Reads the SQL text of an expression stored with a table, such as a CHECK condition or a + * generation expression, independently of the settings of the session that reads it. + */ +object StoredExpressionText { + + /** + * The settings a stored text is read under. The session time zone and case sensitivity stay with + * the given session, because the settings of the DDL are not known here and pinning them would + * silently change existing tables of a non-UTC or a case-sensitive deployment. + */ + def conf(session: SQLConf): SQLConf = { Review Comment: Thank you for the comparison. I kept this out of this PR for the reasons you list. `GenerationExpression` is connector API, every catalog has to round-trip the new field, and tables created in 4.3 need this PR's reading anyway. Findings 6, 7 and 8 are addressed without it in 958490e358a. It can be looked at separately, together with SPARK-60453 as you mention. ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StoredExpressionText.scala: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.util + +import org.apache.spark.sql.catalyst.analysis.{Analyzer, ExpressionWithUnresolvedIdentifier} +import org.apache.spark.sql.catalyst.expressions.{Alias, Expression, ExprId} +import org.apache.spark.sql.catalyst.parser.{ParseException, ParserInterface} +import org.apache.spark.sql.internal.SQLConf + +/** + * Reads the SQL text of an expression stored with a table, such as a CHECK condition or a + * generation expression, independently of the settings of the session that reads it. Review Comment: Applied in 958490e358a. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
