peter-toth commented on PR #59916: URL: https://github.com/apache/spark/pull/59916#issuecomment-6640869881
@dongjoon-hyun, thanks for round 4! It is addressed in [a90e1fb](https://github.com/apache/spark/pull/59916/commits/a90e1fb8b02274ebca49b0364b216577b1d4fd75): - 1, 2 and 4: for a key whose DPP filters are all dropped, the plan that the bloom filter's subquery reads may hold a cache only if scanning it again gives the same rows. The key's type must compare by its bytes. A DPP filter in that plan counts only if it is `onlyInBroadcast`. A scratch run at becfca3 confirmed item 2. - 8: `cannotFail` now builds on `ExprUtils.canEvaluateUnconditionally`. - 3: added to the Known limits. - The rest is answered in the threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
