Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5563#issuecomment-115703939
Hi @ankurcha thanks for updating. I just left a few more teeny tiny
comments. (I think you might have missed one comment I made about a variable
being `private`, but just lemme know if there is a reason it can't be changed.)
@tnachen I understand that there it might be hard to setup tests for a real
mesos cluster, and I don't want to stall all mesos work until that happens.
But for me at least, I'm not comfortable merging a change like this until I
hear that somebody has actually tested it out -- which unfortunately is more
work for the person writing the patch or somebody in the community that
understands mesos + spark. (Though I don't want to stop another committer that
feels its OK.)
That being said, if somebody can do that check, then I think this is ready
to go (with the few minor corrections left).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
