Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/5563#discussion_r33373060
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -17,15 +17,18 @@
package org.apache.spark.scheduler.cluster.mesos
-import java.util.List
import java.util.concurrent.CountDownLatch
+import java.util.{List => JList}
import scala.collection.JavaConversions._
-import org.apache.mesos.Protos.{FrameworkInfo, Resource, Status}
-import org.apache.mesos.{MesosSchedulerDriver, Scheduler}
-import org.apache.spark.Logging
+import com.google.common.base.Splitter
+
+import org.apache.mesos.Protos._
+import org.apache.mesos.{MesosSchedulerDriver, Protos, Scheduler}
import org.apache.spark.util.Utils
+import org.apache.spark.{Logging, SparkContext}
--- End diff --
sorry to nitpick on this again, but still not quite right. the `o.a.spark`
imports get separated. Other `org.apache` imports are not treated specially,
they are the same as `com.foo`. Also reorder the spark imports, so it should be
```scala
import com.google.common.base.Splitter
import org.apache.mesos.Protos._
import org.apache.mesos.{MesosSchedulerDriver, Protos, Scheduler}
import org.apache.spark.{Logging, SparkContext}
import org.apache.spark.util.Utils
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
