Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/6648#discussion_r33620330
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockResolver.scala ---
@@ -23,6 +23,8 @@ import java.util.concurrent.atomic.AtomicInteger
import scala.collection.JavaConversions._
+import com.google.common.annotations.VisibleForTesting
--- End diff --
Hmmm... I wasn't familiar with this. It's an interesting idea, but I'm
left wondering why we would want to use specifically Google's annotation, and
why we would want to use it in this particular file. I'm open to the notion of
this kind of "for testing" marker, and even to adding it in lots of other
places in the Spark code. I'm just not clear about the particular choices
you've made here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
