Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/6648#issuecomment-117353879
Ok, I haven't gone through the test suites in detail yet, but I have looked
at the rest of it; and what is there looks essentially good to me. I need to
come back and look at the test coverage to try to make sure that there isn't
some corner case whose handling is not there and is also not being handled by
the core logic, but mostly what I am seeing right now are cosmetic issues or
things that with a little more polish would make it harder for future
developers to misuse the code.
Nice work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
