Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/6648#discussion_r33621464
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FileShuffleBlockResolver.scala ---
@@ -104,11 +106,12 @@ private[spark] class FileShuffleBlockResolver(conf:
SparkConf)
* Get a ShuffleWriterGroup for the given map task, which will register
it as complete
* when the writers are closed successfully
*/
- def forMapTask(shuffleId: Int, mapId: Int, numBuckets: Int, serializer:
Serializer,
- writeMetrics: ShuffleWriteMetrics): ShuffleWriterGroup = {
+ def forMapTask(shuffleId: Int, mapId: Int, stageAttemptId: Int,
numBuckets: Int,
+ serializer: Serializer, writeMetrics: ShuffleWriteMetrics):
ShuffleWriterGroup = {
--- End diff --
To emphasize the tightly-coupled nature of shuffleId and stageAttemptId, I
guess I would be inclined to make this method use a ShuffleIdAndAttempt instead
of two separate Ints. I'm also not a huge fan of the ShuffleIdAndAttempt name,
but I haven't got a suggestion for a better one at the moment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
