Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/718#discussion_r13366328
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -290,8 +217,88 @@ object HistoryServer {
         }
       }
     
    +  private def parse(args: List[String]): Unit = {
    +    args match {
    +      case ("--dir" | "-d") :: value :: tail =>
    +        set("fs.logDirectory",  value)
    +        parse(tail)
    +
    +      case ("--port" | "-p") :: value :: tail =>
    +        set("ui.port", value)
    +        parse(tail)
    +
    +      case ("-D") :: opt :: value :: tail =>
    +        set(opt, value)
    +        parse(tail)
    +
    +      case ("--help" | "-h") :: tail =>
    +        printUsageAndExit(0)
    +
    +      case Nil =>
    +
    +      case _ =>
    +        printUsageAndExit(1)
    +    }
    +  }
    +
    +  private def set(name: String, value: String) = {
    +    conf.set("spark.history." + name, value)
    +  }
    +
    +  private def printUsageAndExit(exitCode: Int) {
    +    System.err.println(
    +      """
    +      |Usage: HistoryServer [options]
    +      |
    +      |Options are set by passing "-D option value" command line arguments 
to the class.
    +      |Command line options will override the Spark configuration file and 
system properties.
    --- End diff --
    
    I don't think the Spark configuration file would ever be read here 
(presently that file is just for `spark-submit`). I would just say it overrides 
system properties.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to