Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/718#discussion_r13367189
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -290,8 +217,88 @@ object HistoryServer {
         }
       }
     
    +  private def parse(args: List[String]): Unit = {
    +    args match {
    +      case ("--dir" | "-d") :: value :: tail =>
    +        set("fs.logDirectory",  value)
    +        parse(tail)
    +
    +      case ("--port" | "-p") :: value :: tail =>
    +        set("ui.port", value)
    +        parse(tail)
    +
    +      case ("-D") :: opt :: value :: tail =>
    --- End diff --
    
    I think this was somewhat intentionally designed to only take a single 
required argument. Checkout the existing docs for the history server:
    http://spark.apache.org/docs/latest/monitoring.html
    
    Doesn't this also break compatibility with 1.0 as well?
    
    Separately, I'd rather not overload `-D` in general. This seems to actually 
have different syntax than the normal `-D` where you do `-Dkey=value`. Here 
it's `-D key value`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to