Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/718#issuecomment-45041212
Hey @vanzin - I just did a pass on this. From what I can tell this adds
four somewhat independent changes:
1. Caching applications that we know haven't changed.
2. Adding pagination to the list of applications.
3. Abstracting the history provider.
4. Replacing the way arguments are specified to the server.
Of these, I feel that (1) and (2) are great improvements. It might be nice
to pull those out into a separate PR, because here they are somewhat conflated
with (3) and (4).
For (3) - I think it might make more sense to wait until we have two
concrete implementations here before we decided to make an interface. Otherwise
I think it's very likely we'd end up changing the interface anyways down the
road. And this isn't a public API - we can easily just generalize it whenever
we want. @andrewor14 can comment on this more next week when he's back, since
he made this original design.
For (4) the proposal here, I wasn't sure exactly what problem it was trying
to solve. It would be good to have more information on that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
