Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/369#discussion_r13422474
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
@@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
def ++(other: RDD[T]): RDD[T] = this.union(other)
/**
+ * Return this RDD sorted by the given key function.
+ */
+ def sortBy[K](
+ f: (T) â K,
+ ascending: Boolean = true,
+ numPartitions: Int = this.partitions.size)
+ (implicit ord: Ordering[K], ctag: ClassTag[K]): RDD[T] =
--- End diff --
@markhamstra I checked RDD.scala and found the style you talked about. But
one thing I don't understand is:`def countByValue()(implicit ord: Ordering[T] =
null)`. I can't find the use of implicit `Ordering[T]` anywhere inside the
method, and I compiled spark successfully with this implicit Ordering[T]
removed. Did I miss something here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
