Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7602#issuecomment-125854520
I think this actually makes it worse, since it is not only accumulating the
result in a `StringBuilder`, but always converting it to a `String` as the
return value from each recursive call. That's not needed, is it? Without that,
I imagine this is a small improvement, but I also do not think this can prevent
an OOM. In its current state I definitely don't see how this fixes the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]