Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/718#discussion_r13564133
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -290,8 +212,81 @@ object HistoryServer {
}
}
+ private def parse(args: List[String]): Unit = {
--- End diff --
I would prefer this to be moved back to HistoryServerArguments.scala, which
you removed. This is consistent with the standalone master web UI
(MasterArguments.scala) and spark submit (SparkSubmitArguments.scala) among
other places, and just keeps the main HistoryServer.scala smaller.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
