Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/718#issuecomment-45128194
Okay - we can keep the changes together. I think the test-ability argument
is a good one for abstracting away the interface. We typically try not to add
interfaces until we have two concrete implementations... but again, for
internal code it's not a big deal since we can always refactor it later.
Re: reviewboard, we have a bunch of project automation around github, but
it's possible reveiwboard could augment this somehow (not sure). Would be
interesting to look into. There is no way to do an incremental diff in github,
which is indeed super annoying, however in the past that feature hasn't been
seen as outweighing the other benefits. I'd guess people are open to
experimentation!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
