Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/718#discussion_r13564491
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -290,8 +212,81 @@ object HistoryServer {
         }
       }
     
    +  private def parse(args: List[String]): Unit = {
    +    args match {
    +      case ("--dir" | "-d") :: value :: tail =>
    +        set("fs.logDirectory",  value)
    +        parse(tail)
    +
    +      case ("-D") :: opt :: value :: tail =>
    +        set(opt, value)
    +        parse(tail)
    +
    +      case ("--help" | "-h") :: tail =>
    +        printUsageAndExit(0)
    +
    +      case Nil =>
    +
    +      case _ =>
    +        printUsageAndExit(1)
    +    }
    +  }
    +
    +  private def set(name: String, value: String) = {
    +    conf.set("spark.history." + name, value)
    +  }
    +
    +  private def printUsageAndExit(exitCode: Int) {
    +    System.err.println(
    +      """
    +      |Usage: HistoryServer [options]
    +      |
    +      |Options are set by passing "-D option value" command line arguments 
to the class.
    +      |Command line options will override JVM system properties (which 
should be prepended
    +      |with "spark.history.").
    +      |
    +      |History Server options are always available; additional options 
depend on the provider.
    +      |
    +      |History Server options:
    +      |
    +      |  ui.port           Port where server will listen for connections 
(default 18080)
    +      |  ui.acls.enable    Whether to enable view acls for all 
applications (default false)
    +      |  provider          Name of history provider class (defaults to 
file system-based provider)
    +      |
    +      |FsHistoryProvider options:
    +      |
    +      |  fs.logDirectory   Directory where app logs are stored (required)
    +      |  fs.updateInterval How often to reload log data from storage 
(seconds, default 10)
    --- End diff --
    
    You should also update the documentation in `configuration.md`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to