Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7855#discussion_r37118542
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -211,4 +215,80 @@ trait ExpressionEvalHelper {
plan(inputRow)).get(0, expression.dataType)
assert(checkResult(actual, expected))
}
+
+ def checkConsistency(dt: DataType, clazz: Class[_]): Unit = {
--- End diff --
What do you think about giving this a more specific name, such as
`checkConsistencyBetweenInterpretedAndCodegen`? It would also be good to add
Scaladoc to these methods to explain what they're doing, since the use of
reflection might be non-obvious.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
