Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7855#discussion_r37119904
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -211,4 +215,80 @@ trait ExpressionEvalHelper {
plan(inputRow)).get(0, expression.dataType)
assert(checkResult(actual, expected))
}
+
+ def checkConsistency(dt: DataType, clazz: Class[_]): Unit = {
--- End diff --
Also, I think that we might be able to clean up the code slightly by adding
a type to this method:
```scala
def checkConsistency[E <: Expression: ClassTag](dt: DataType)
```
to let callers write something like
```scala
checkConsistencyBetweenInterpretedAndCodegen[Sinh](DoubleType)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
