Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7855#discussion_r37119701
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralGenerator.scala
---
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions
+
+import java.sql.{Date, Timestamp}
+
+import org.scalacheck.{Arbitrary, Gen}
+import org.scalatest.Matchers
+import org.scalatest.prop.GeneratorDrivenPropertyChecks
+
+import org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types.CalendarInterval
+
+/**
+ * Property is a high-level specification of behavior that should hold for
a range of data points.
+ *
+ * For example, while we are evaluating a deterministic expression for
some input, we should always
+ * hold the property that the result never changes, regardless of how we
get the result,
+ * via interpreted or codegen.
+ *
+ * In ScalaTest, properties are specified as functions and the data points
used to check properties
+ * can be supplied by either tables or generators.
+ *
+ * Generator-driven property checks are performed via integration with
ScalaCheck.
+ *
+ * @example {{{
+ * def toTest(i: Int): Boolean = if (i % 2 == 0) true else false
+ *
+ * import org.scalacheck.Gen
+ *
+ * test ("true if param is even") {
+ * val evenInts = for (n <- Gen.choose(-1000, 1000)) yield 2 * n
+ * forAll(evenInts) { (i: Int) =>
+ * assert (toTest(i) === true)
+ * }
+ * }
+ * }}}
+ *
+ */
+trait LiteralGenerator {
--- End diff --
Should this be a trait? What about making it into an object named
`LiteralGenerators`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
