Github user CodingCat commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8533#discussion_r38831357
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -322,7 +333,12 @@ private[spark] class TaskSetManager(
           // Check for node-local tasks
           if (TaskLocality.isAllowed(locality, TaskLocality.NODE_LOCAL)) {
             for (index <- speculatableTasks if canRunOnHost(index)) {
    -          val locations = tasks(index).preferredLocations.map(_.host)
    +          val locations = if ( sparkLocalHostname != None ) {
    --- End diff --
    
    there are cases which we didn't cover in the scala style rules but are 
actually imposed "manually"....
    
    e.g. even you remove the spaces around `=`, it still passes the scala style 
checks.....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to