Github user kayousterhout commented on the pull request:
https://github.com/apache/spark/pull/8533#issuecomment-138653698
I have all of the same reservations that @srowen mentioned -- I know we've
had many issues in the past getting all of the addresses to match up in the way
that they should, and I'm concerned that this change will introduce other
issues with getting the hostnames to line up. Happy to defer to @andrewor14 /
@JoshRosen if either of you is convinced that this change lines up with all of
the other ways that we use the host name / address elsewhere in the code.
If others decide this change is correct, one issue with this particular
implementation is that it's very unclear to a naive reader of the code why the
presence or absence of the SPARK_LOCAL_HOSTNAME variable should change how we
interpret an address. I think one of the intermediate versions was more clear
in this regard.
As an aside, one change that would help with this overall issue is if we
more clearly named things as either host name or host IP address (the current
variable names don't make this clear).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
