Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7786#discussion_r40030138
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala
 ---
    @@ -94,4 +94,5 @@ private[spark] object CoarseGrainedClusterMessages {
     
       case class KillExecutors(executorIds: Seq[String]) extends 
CoarseGrainedClusterMessage
     
    +  case class PreemptionExecutors(executorIds: Set[String]) extends 
CoarseGrainedClusterMessage
    --- End diff --
    
    +1. In fact, since you're sending a message saying which executors are 
about to be pre-empted, a better name would be `PreemptedExecutors`. Same thing 
everywhere else in this patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to