Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7786#discussion_r40236632
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala ---
    @@ -346,7 +347,16 @@ private[spark] class ApplicationMaster(
                     "Max number of executor failures reached")
                 } else {
                   logDebug("Sending progress")
    -              allocator.allocateResources()
    +              allocator.updateResources()
    +
    +              // Get the preemption executors from YarnAllocator, if 
preemption executor list is
    +              // changed compared to last time, notify scheduler backend 
this preemption executor
    +              // list.
    +              val preemptionExecutors = allocator.getPreemptionExecutors
    +              if (preemptionExecutors != lastPreemptionExecutors) {
    +                amEndpoint.send(PreemptionExecutors(preemptionExecutors))
    --- End diff --
    
    I would incline to use `amEndpoint` here as to keep consistent with other 
places like `AddWebFIlter`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to