Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1147#discussion_r14051287
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -29,30 +29,25 @@ import org.apache.spark.sql.columnar.{InMemoryRelation, 
InMemoryColumnarTableSca
     private[sql] abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
       self: SQLContext#SparkPlanner =>
     
    -  object LeftSemiJoin extends Strategy with PredicateHelper {
    +  object JoinOperatorSelection extends Strategy with PredicateHelper {
    +    // put all of the join strategy here, since the match ordering is 
quite critical for
    --- End diff --
    
    Putting all of the join types in a single strategy means that we will never 
consider multiple ways to execute a given join.  The whole point of strategies 
is that we can eventually add cost based optimizations as part of the 
QueryPlanner infrastructure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to