Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1147#discussion_r14051302
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
@@ -249,12 +297,15 @@ case class LeftSemiJoinBNL(
* :: DeveloperApi ::
*/
@DeveloperApi
-case class CartesianProduct(left: SparkPlan, right: SparkPlan) extends
BinaryNode {
+case class CartesianProduct(left: SparkPlan, right: SparkPlan,
--- End diff --
What was the wrong with the way this was before? By duplicating the logic
for doing filtering you are making this operator more complicated and now when
we do things like codegen we are going to have to make changes to condition
evaluation in two places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
