Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1147#discussion_r14051296
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins.scala ---
@@ -36,158 +37,211 @@ case object BuildLeft extends BuildSide
case object BuildRight extends BuildSide
/**
- * :: DeveloperApi ::
+ * Output the tuples for the matched (with the same join key) join groups,
accordingly to join type
*/
-@DeveloperApi
-case class HashJoin(
- leftKeys: Seq[Expression],
- rightKeys: Seq[Expression],
- buildSide: BuildSide,
- left: SparkPlan,
- right: SparkPlan) extends BinaryNode {
+trait BinaryJoinNode extends BinaryNode {
+ self: Product =>
- override def outputPartitioning: Partitioning = left.outputPartitioning
+ val SINGLE_NULL_LIST = Seq[Row](null)
--- End diff --
Let's stick to `camelCase`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
