Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9241#discussion_r42953261
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala ---
@@ -27,6 +29,11 @@ import org.apache.spark.memory.{StaticMemoryManager,
MemoryManager}
import org.apache.spark.storage.{BlockId, BlockStatus}
import org.apache.spark.unsafe.array.ByteArrayMethods
+abstract class MemoryConsumer {
+ @throws[IOException]
+ def release(numBytes: Long): Long
--- End diff --
We should add Scaladoc here to clarify that this is asking the consumer to
release memory but that the consumer might release more or less memory than we
asked for (or none at all!). Should we give this method a different name that
suggests this, such as `askToRelease()`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
