Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9241#discussion_r42953355
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/ShuffleMemoryManager.scala ---
@@ -152,6 +199,11 @@ class ShuffleMemoryManager protected (
taskMemory.remove(taskAttemptId).foreach { numBytes =>
memoryManager.releaseExecutionMemory(numBytes)
}
+ taskConsumers.remove(taskAttemptId).map { consumers =>
+ consumers.foreach { case (consumer, numBytes) =>
+ logWarning(s"Memory leak in task $taskAttemptId: $consumer
$numBytes bytes")
--- End diff --
Same here; I think this should be an exception in unit tests and a warning
in production.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
