Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6263#discussion_r43909507
  
    --- Diff: 
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala 
---
    @@ -150,4 +158,12 @@ class StorageStatusListenerSuite extends FunSuite {
         listener.onUnpersistRDD(SparkListenerUnpersistRDD(1))
         assert(listener.executorIdToStorageStatus("big").numBlocks === 0)
       }
    +  
    +  test("Killed Executor Entry removed after configurable time") {
    +    val localtestconf = new 
SparkConf().set(StorageStatusListener.TIME_TO_EXPIRE_KILLED_EXECUTOR,"5s")
    +    val listener = new StorageStatusListener(localtestconf)
    +    listener.removedExecutorIdToStorageStatus.put("1", new 
StorageStatus(null, 50))
    +    Thread.sleep(5500)
    --- End diff --
    
    you can avoid sleeping by using 
[`cache.setTicker`](https://github.com/google/guava/wiki/CachesExplained#testing-timed-eviction)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to