Github user archit279thakur commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r43982245
--- Diff:
core/src/test/scala/org/apache/spark/storage/StorageStatusListenerSuite.scala
---
@@ -150,4 +158,12 @@ class StorageStatusListenerSuite extends FunSuite {
listener.onUnpersistRDD(SparkListenerUnpersistRDD(1))
assert(listener.executorIdToStorageStatus("big").numBlocks === 0)
}
+
+ test("Killed Executor Entry removed after configurable time") {
+ val localtestconf = new
SparkConf().set(StorageStatusListener.TIME_TO_EXPIRE_KILLED_EXECUTOR,"5s")
+ val listener = new StorageStatusListener(localtestconf)
+ listener.removedExecutorIdToStorageStatus.put("1", new
StorageStatus(null, 50))
+ Thread.sleep(5500)
--- End diff --
For that we'll have to set an arbitrary ticker to the main cache, We would
not want to set any arbitrary ticker to the original cache. Creating a new
cache in the test would not be testing of our functionality and would be
equivalent of testing just the Guava Cache's code. right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
