Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6263#discussion_r44055116
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -17,26 +17,55 @@
package org.apache.spark.storage
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConversions.collectionAsScalaIterable
--- End diff --
avoid using JavaConversions, you should prefer JavaConverters, which forces
you to call `.asScala`, making the transformation much clearer to future code
readers. the convention is to `import scala.collection.JavaConverters._`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
