Github user concretevitamin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1238#discussion_r14573140
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -61,8 +61,6 @@ private[sql] abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
           condition.map(Filter(_, 
broadcastHashJoin)).getOrElse(broadcastHashJoin) :: Nil
         }
     
    -    def broadcastTables: Seq[String] = 
sqlContext.joinBroadcastTables.split(",").toBuffer
    -
         def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
    --- End diff --
    
    For the config option to control the size-based conversion: what do people 
think about this? I'd note that Hive does have such a switch, yet if users want 
to turn off the conversion, setting the threshold to zero effectively achieves 
the same thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to