Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/1238#discussion_r14676932
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -26,6 +26,17 @@ import org.apache.spark.sql.catalyst.trees
abstract class LogicalPlan extends QueryPlan[LogicalPlan] {
self: Product =>
+ protected class Estimates {
--- End diff --
- I think `Statistics` might be a better name than `Estimates`. This is
because eventually I think this class will also contain things like per-column
information like # of distinct elements, or even histograms.
- What do you think about making this a case class? I think there are two
advantages here over the current scheme:
- Two levels of lazyness might be overkill.
- With case classes, propagation could be done using a copy constructor,
changing only the required values. I think this might become more important as
we add more fields to this class.
- It would prevent a proliferation of anonymous classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
