Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/1238#discussion_r14581868
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -26,6 +26,17 @@ import org.apache.spark.sql.catalyst.trees
abstract class LogicalPlan extends QueryPlan[LogicalPlan] {
self: Product =>
+ protected class Estimates {
+ lazy val childrenEstimations = children.map(_.estimates)
+ lazy val cardinality: Long = childrenEstimations.map(_.cardinality).sum
+ lazy val sizeInBytes: Long = childrenEstimations.map(_.sizeInBytes).sum
--- End diff --
@concretevitamin maybe there is some misunderstanding, I mean we should set
a bigger default value for sizeInBytes, like Long.MAX_VALUE or something? 0 is
actually a meaningful value, like for an empty table.
BTW, I don't see where we use the `cardinality` of `Estimates`, is it for
the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
