Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/9796#discussion_r45384135
--- Diff:
core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
@@ -395,8 +395,8 @@ class StandaloneDynamicAllocationSuite
}
var apps = getApplications()
- // kill executor 1
- assert(sc.killExecutor(executors.head))
+ // kill executor 1, and actually nothing to kill
+ assert(!sc.killExecutor(executors.head))
--- End diff --
I think this may be a bigger problem. This is supposed to be `true` because
it's a new executor so we should be able to kill it. I think it's the way this
test is set up that makes this false, because the driver doesn't wait for new
executors to come up. We might need to do some more mocking here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
