Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r45582811
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -218,7 +218,7 @@ private object IDFModel {
newValues(k) = values(k) * idf(indices(k))
k += 1
}
- Vectors.sparse(n, indices, newValues)
+ Vectors.sparse(n, indices, newValues).toSparse
--- End diff --
Hm, that's already a fairly heavy operation, so I tend to think it's OK to
filter out explicit zeroes. @jkbradley am I missing anything? seems like a win.
I'm trying to think of why any code would legitimately rely on an explicit 0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
