Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r45962467
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -218,7 +218,7 @@ private object IDFModel {
newValues(k) = values(k) * idf(indices(k))
k += 1
}
- Vectors.sparse(n, indices, newValues)
+ Vectors.sparse(n, indices, newValues).toSparse
--- End diff --
Makes some sense but `Vectors.sparse` is already doing some expensive
operations like a sort. A filter doesn't seem like much extra.
I get that someone setting 0 directly into a sparse vector might want it to
literally record it, but is that someone's expectation in passing it into a
factory method?
Anyway maybe you're on to something here, just sounds funny that we have to
separately count non-zero elements
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
