Github user karlhigley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r45901371
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -218,7 +218,7 @@ private object IDFModel {
newValues(k) = values(k) * idf(indices(k))
k += 1
}
- Vectors.sparse(n, indices, newValues)
+ Vectors.sparse(n, indices, newValues).toSparse
--- End diff --
Making the change above breaks the `foreachActive`
[test](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala#L281),
which counts the explicit zeros as active elements. I can't think of why code
would rely on explicit zeros in `foreachActive`, but that's where the potential
breakage lies. (The rest of the MLlib tests pass.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
