Github user karlhigley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9843#discussion_r46013714
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala ---
@@ -218,7 +218,7 @@ private object IDFModel {
newValues(k) = values(k) * idf(indices(k))
k += 1
}
- Vectors.sparse(n, indices, newValues)
+ Vectors.sparse(n, indices, newValues).toSparse
--- End diff --
If the `Array` version of the method is commonly used because it contains
some additional conveniences and safety checks, that would align with @srowen's
point that the expectations may be different for a factory method. If that's
what's driving the preferred usage of the `Array` version, it would tip me
toward filtering out explicit zeros there (prior to the sort).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
