Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10209#discussion_r47227527
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -356,6 +360,51 @@ object LikeSimplification extends Rule[LogicalPlan] {
}
/**
+ * This rule adds IsNotNull predicates based on join keys. If the join
contains a condition
+ * `a` binaryOp *, a is non-nullable. This adds filters for those
attributes to the children.
+ *
+ * To avoid the problem of repeatedly generating the IsNotNull predicates,
the join operator
+ * remembers all the expressions it generated.
+ */
+object AddJoinKeyNullabilityFilters extends Rule[LogicalPlan] with
PredicateHelper {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case j @ Join(left, right, Inner, Some(condition), generated) => {
+ val nonNullableKeys = ExtractNonNullableAttributes.unapply(condition)
--- End diff --
nit: `val ExtractNonNullableAttributes(nonNullableKeys) = condition`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
