Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10209#discussion_r47291050
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
 ---
    @@ -122,11 +122,22 @@ case class Except(left: LogicalPlan, right: 
LogicalPlan) extends SetOperation(le
       override def output: Seq[Attribute] = left.output
     }
     
    +object Join {
    +  def apply(
    +    left: LogicalPlan,
    +    right: LogicalPlan,
    +    joinType: JoinType,
    +    condition: Option[Expression]): Join = {
    +    Join(left, right, joinType, condition, None)
    +  }
    +}
    +
     case class Join(
       left: LogicalPlan,
       right: LogicalPlan,
       joinType: JoinType,
    -  condition: Option[Expression]) extends BinaryNode {
    +  condition: Option[Expression],
    +  generatedExpressions: Option[EquivalentExpressions]) extends BinaryNode {
    --- End diff --
    
    I started down that path but can you think of a way to make that handle the 
more general case of predicate propagation?
    
    t1.key join t2.key where t1.key = t2.key and t1.key = 5.
    
    How do we generate the predicate t2.key = 5? how do we make this more 
general? 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to