Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10209#discussion_r47268378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -99,6 +99,13 @@ abstract class LogicalPlan extends
QueryPlan[LogicalPlan] with Logging {
*/
lazy val resolved: Boolean = expressions.forall(_.resolved) &&
childrenResolved
+ /**
+ * Returns true if the two plans are semantically equal. This should
ignore state generated
+ * during planning to help the planning process.
+ * TODO: implement this as a pass that canonicalizes the plan tree
instead?
+ */
+ def semanticEquals(other: LogicalPlan): Boolean = this == other
--- End diff --
Oh, this is a new semantic equals. How is this different than
`sameResult`? Maybe we should unify the naming between Expression and
LogicalPlan for this concept.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
