Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10384#discussion_r48239605
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala 
---
    @@ -23,15 +23,23 @@ import org.apache.spark.Logging
     import org.apache.spark.mllib.linalg.Vectors
     import org.apache.spark.mllib.stat.{MultivariateStatisticalSummary, 
MultivariateOnlineSummarizer}
     import org.apache.spark.sql.DataFrame
    -
     /**
      * Evaluator for regression.
      *
    - * @param predictionAndObservations an RDD of (prediction, observation) 
pairs.
    + * @param predictionAndObservations an RDD of (prediction, observation) 
pairs,
    + * @param regThroughOrigin true if intercept is not included in linear 
regression model
    --- End diff --
    
    Should we just call it `hasIntercept` or `fitIntercept` for consistency 
with other code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to