Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48390247
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RegressionMetrics.scala
---
@@ -23,15 +23,23 @@ import org.apache.spark.Logging
import org.apache.spark.mllib.linalg.Vectors
import org.apache.spark.mllib.stat.{MultivariateStatisticalSummary,
MultivariateOnlineSummarizer}
import org.apache.spark.sql.DataFrame
-
/**
* Evaluator for regression.
*
- * @param predictionAndObservations an RDD of (prediction, observation)
pairs.
+ * @param predictionAndObservations an RDD of (prediction, observation)
pairs,
+ * @param regThroughOrigin true if intercept is not included in linear
regression model
--- End diff --
That makes sense. Could you change `regThroughOrigin` to `throughOrigin`
since reg is often used as regularization. Also, could you update the scala doc
saying that `True if the regression is through the origin. For example, in
linear regression, it will be true without fitting intercept`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
