Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10384#discussion_r48252529
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/RegressionMetricsSuite.scala
---
@@ -22,91 +22,115 @@ import
org.apache.spark.mllib.util.MLlibTestSparkContext
import org.apache.spark.mllib.util.TestingUtils._
class RegressionMetricsSuite extends SparkFunSuite with
MLlibTestSparkContext {
+ val obs = List[Double](77, 85, 62, 55, 63, 88, 57, 81, 51)
+ val eps = 1E-5
test("regression metrics for unbiased (includes intercept term)
predictor") {
--- End diff --
I think @iyounus made up a new test that is then used for both cases. Yeah
it'd be kind of good to see that the old test still passes, but this is pretty
reliably benchmarked vs R now and is a slightly better test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
