Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/10368#discussion_r48385365
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -215,6 +215,18 @@ class TaskMetrics extends Serializable {
inputMetrics.foreach(_.updateBytesRead())
}
+ override def equals(other: Any): Boolean = other match {
--- End diff --
This is not a correct `equals`. There are other fields in `TaskMetrics`. To
make `TaskMetrics.equals` work, there are also other classes need to be
updated. Instead, could you just manually compare fields of DirectTaskResult in
the tests rather than adding an incorrect `equals`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
