Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/10368#discussion_r48389119 --- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala --- @@ -215,6 +215,18 @@ class TaskMetrics extends Serializable { inputMetrics.foreach(_.updateBytesRead()) } + override def equals(other: Any): Boolean = other match { --- End diff -- yeah, that would be preferable actually. In the future if we add more fields to `TaskMetrics` we might forget to add it to `equals`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org