Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10464#discussion_r48527726
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/SocketInputDStream.scala
---
@@ -52,34 +52,40 @@ class SocketReceiver[T: ClassTag](
storageLevel: StorageLevel
) extends Receiver[T](storageLevel) with Logging {
+ var socket: Socket = null
+
def onStart() {
+ logInfo("Connecting to " + host + ":" + port)
+ socket = new Socket(host, port)
+ logInfo("Connected to " + host + ":" + port)
+
// Start the thread that receives data over a connection
new Thread("Socket Receiver") {
setDaemon(true)
- override def run() { receive() }
+ override def run() { receive(socket) }
}.start()
}
def onStop() {
- // There is nothing much to do as the thread calling receive()
- // is designed to stop by itself isStopped() returns false
+ if (socket != null) {
+ socket.close()
--- End diff --
The finally block was left below though. It will cause the socket to be
closed twice. It seems like it should be closed one place, or at least nulled
in the finally block. But then you need to synchronize too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
