Github user guoxu1231 commented on the pull request:
https://github.com/apache/spark/pull/10464#issuecomment-167802563
Thanks @srowen, look like previous receive() method included many logic
inside (create socket, release socket, restart in case non-fatch exception), I
almost missed the restart in case ConnectException. thanks for the review.
I removed the synchronized block as well, because I found socket.close() is
synchronized method.
and also improved some minor IDE suggested fix.
I'm newbie in scala development, thanks for the detailed review suggestion.
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
